make passwordCurrent an optional param #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Perfect! Thanks @bentedder for catching this error! |
|
Please push these changes to npm. |
neroniaky
added a commit
that referenced
this pull request
Jun 19, 2022
make passwordCurrent an optional param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the passwordCurrent attribute optional in the interface. Check out the problems when trying to reset a password when the user is not already authenticated or has forgotten their password. Setting this property to null before sending it fixes the problem, so just having a model that doesn't require it should prevent the workaround.
#205 (comment)
Here the property is already been checked against "null", meaning if it's a required string this line of code will never be reached: https://github.com/neroniaky/angular2-token/blob/master/src/angular2-token.service.ts#L270