-
Notifications
You must be signed in to change notification settings - Fork 42
Fix auth_app for modern Taiga versions (#227) #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix auth_app for modern Taiga versions (#227) #229
Conversation
8b25288
to
5a4f5a8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 96.47% 97.07% +0.60%
==========================================
Files 8 8
Lines 936 923 -13
Branches 67 64 -3
==========================================
- Hits 903 896 -7
+ Misses 19 16 -3
+ Partials 14 11 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi, any news on getting this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the incompatible signature of auth_app we should release this with a major version bump and documenting the breaking change in the documentation
Description
auth_app()
to (only) work with Taiga 3.1.0+ (released in 2016).auth()
- rather, it only works once per token because the Taiga backend invalidates theauth_code
during the request. From what I can tell, applications are supposed to store and re-use the token. It doesn't have an expiration, unlike Bearer tokens.References
Fixes #227
Due to removal of dependency, also fixes #189
Checklist
inv lint
changes
file included (see docs)