Change ExpiringAuth.expires_in to expires_at #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the preview feature to be more in line with other drivers and support more SSO flows, of which some specify token lifetime with an absolute time value while other flows use relative time. Now, there's both options: * absolute: `ExpiringAuth(some_auth, expires_at=...)` * relative: `ExpiringAuth(some_auth).expires_in(...)` (or doing it manually `ExpiringAuth(some_auth, expires_at=time.time() + expires_in)`)
fbiville
approved these changes
May 22, 2023
| @pytest.mark.parametrize(("auth1", "auth2"), | ||
| itertools.product(SAMPLE_AUTHS, repeat=2)) | ||
| @pytest.mark.parametrize("expires_in", (None, -1, 1., 1, 1000.)) | ||
| @pytest.mark.parametrize("expires_at", (None, -1, 1., 1, 1000.)) |
There was a problem hiding this comment.
they really made a typo in the decorator name? ouch :/
There was a problem hiding this comment.
You mean parametrized vs. parameterized?
Seems to be a controversial topic 🔥 https://english.stackexchange.com/questions/79847/parametrise-or-parameterise-a-curve
ConorNeo
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the preview feature to be more in line with other drivers and support more SSO flows, of which some specify token lifetime with an absolute time value while other flows use relative time.
Now, there's both options:
ExpiringAuth(some_auth, expires_at=...)ExpiringAuth(some_auth).expires_in(...)(or doing it manuallyExpiringAuth(some_auth, expires_at=time.time() + expires_in))