Fixing documentation and type hints #927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When renaming some of the re-auth APIs before stabilizing them in 3.8, some references in the docs were missed. * The docs for `ExpiringAuth` was completely missing becuase the `@preview` decorator broke sphinx. * Fix typing change in `datetime.replace` breaking us (arguments were changed from type `int` to `SupportsIndex`). As a virtual subclass, our custom temporal types should follow this change. * Fix broken layout of `execute_query` parameter docs.
fbiville
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpiringAuthwas completely missing becuase the@previewdecorator broke sphinx.datetime.replacebreaking us (arguments were changed from typeinttoSupportsIndex). As a virtual subclass, our custom temporal types should follow this change.execute_queryparameter docs.