New timeout config options [ADR 006] #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should retry finding an idle connection after being woken up
robsdedude
force-pushed
the
connection-acquisition-timeout-routing
branch
from
a805f38 to
07f8bb2
Compare
robsdedude
force-pushed
the
connection-acquisition-timeout-routing
branch
from
07f8bb2 to
43ddb35
Compare
robsdedude
commented
Jun 22, 2022
robsdedude
commented
Jun 22, 2022
robsdedude
commented
Jun 22, 2022
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Jun 22, 2022
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Jun 22, 2022
robsdedude
force-pushed
the
connection-acquisition-timeout-routing
branch
from
32d6de1 to
56b7b53
Compare
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Jun 22, 2022
robsdedude
changed the title
|
Stub tests are expected to fail because of the UTC fix not being implemented in the Driver yet. |
bigmontz
reviewed
Jun 23, 2022
| acquire_kwargs_ = { | ||
| "access_mode": access_mode, | ||
| "timeout": self._config.connection_acquisition_timeout, | ||
| "timeout": timeout, |
There was a problem hiding this comment.
It feels a bit strange to figure out what is happen here, because of the timeout field being filled with a Deadline. It's not a major issue, since the code knows how to handle it.
robsdedude
force-pushed
the
connection-acquisition-timeout-routing
branch
from
ac6ded7 to
4f8190d
Compare
robsdedude
force-pushed
the
connection-acquisition-timeout-routing
branch
from
4f8190d to
74b06ee
Compare
|
multi-db Integration tests with 5.0 are failing because the async nature of db management procedure changed (neo4j-drivers/testkit#484) -> unrelated to this change. |
robsdedude
added a commit
that referenced
this pull request
Jun 28, 2022
* Backport new connection timeout config options Backport of #745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #675
Implements ADR 006 (internal reference)