Adjust Retryable Errors #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecate `is_retriable()` in favor of `is_retryable`
* Rewrite errors for backwards compatibility
* Neo.TransientError.Transaction.Terminated
-> Neo.ClientError.Transaction.Terminated
* Neo.TransientError.Transaction.LockClientStopped
-> Neo.ClientError.Transaction.LockClientStopped
* Add unit tests
robsdedude
added a commit
to neo4j-drivers/testkit
that referenced
this pull request
Jun 14, 2022
* Python has a fix prepared: neo4j/neo4j-python-driver#742 * Ruby is not part of our pipelines and hence needs no exception just to get our TestKit pipelines green. The maintainers should, however, notice through failing tests that there is work required, once they upgrade to 5.0
robsdedude
added a commit
to neo4j-drivers/testkit
that referenced
this pull request
Jul 7, 2022
* Python has a fix prepared: neo4j/neo4j-python-driver#742 * Ruby is not part of our pipelines and hence needs no exception just to get our TestKit pipelines green. The maintainers should, however, notice through failing tests that there is work required, once they upgrade to 5.0
robsdedude
force-pushed
the
rewrite-retryable-exceptions
branch
from
17bb81b to
72c2251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_retriable()in favor ofis_retryable-> Neo.ClientError.Transaction.Terminated
-> Neo.ClientError.Transaction.LockClientStopped
Amends #682
Depends on neo4j-drivers/testkit#466