Skip to content

Fix neo4j.time #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2022
Merged

Fix neo4j.time #683

merged 3 commits into from
Mar 31, 2022

Conversation

@robsdedude
Copy link
Member

@robsdedude robsdedude commented Mar 18, 2022 •
edited
Loading

@robsdedude
Fix serialization of DateTime
9553730 
DateTime objects with fixed negative UTC offset were incorrectly serialized
and sent to the database.

Similar issue to neo4j#616
@robsdedude robsdedude mentioned this pull request Mar 18, 2022
Merged
@robsdedude robsdedude changed the title Fix serialization of DateTime Fix neo4j.time Mar 18, 2022
@robsdedude robsdedude force-pushed the fix-datetime-offset-serialization branch from c98ec38 to bd40cb1 Compare March 29, 2022 14:52
@robsdedude robsdedude force-pushed the fix-datetime-offset-serialization branch from bd40cb1 to 4725ce1 Compare March 29, 2022 15:08
@robsdedude
Improve compatibility with timezone implementations
621b8dc 
Not all implementations of timezones play nicely with custom datetime
implementations. In such cases, we need to fall back to native datetimes.
AndyHeap-NeoTech
AndyHeap-NeoTech approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks sensible to me.

robsdedude added a commit that referenced this pull request Mar 31, 2022
@robsdedude
Merge pull request #684 from robsdedude/fix-datetime-offset-serializa…
5dd635d 
…tion-4.4

[4.4] Fix `neo4j.time`
Backport of #683
@robsdedude robsdedude merged commit 52450a4 into neo4j:5.0 Mar 31, 2022
@robsdedude robsdedude deleted the fix-datetime-offset-serialization branch March 31, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyHeap-NeoTech AndyHeap-NeoTech AndyHeap-NeoTech approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robsdedude @AndyHeap-NeoTech