Skip to content

[4.3] Use selectors.DefaultSelector over select.select #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2021
Merged

[4.3] Use selectors.DefaultSelector over select.select #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions neo4j/io/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
)
from logging import getLogger
from random import choice
from select import select
import selectors
from socket import (
AF_INET,
AF_INET6,
Expand Down Expand Up @@ -1262,8 +1262,9 @@ def _handshake(s, resolved_address):

# Handle the handshake response
ready_to_read = False
while not ready_to_read:
ready_to_read, _, _ = select((s,), (), (), 1)
with selectors.DefaultSelector() as selector:
selector.register(s, selectors.EVENT_READ)
selector.select(1)
try:
data = s.recv(4)
except OSError:
Expand Down