Send BEGIN eagerly on transaction begin #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
eager-begin
branch
2 times, most recently
from
0655ce1 to
5a879ce
Compare
robsdedude
force-pushed
the
eager-begin
branch
from
5a879ce to
92f314a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By sending
BEGINright after starting a transaction instead of waiting fora query to pipeline
BEGINwithRUN, the driver will notice a brokenconnection, lack of permission, and similar problems faster. Meaning potentially
expensive computations in the client code can be avoided if they wouldn't be
able to be persisted in the DB anyway. However, this means an extra rtt.
Waiting for neo4j-drivers/testkit#251 to me merged first (re-run TestKit pipeline afterwards)