Fix examples #160
Merged
Fix examples #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srbaker It seems the import will fail on 3.4 due to missing path. I think this should fix the problem |
added 3 commits
April 27, 2017 14:57
Removed some test assumption that is no longer true for server 3.2 to avoid test error
zhenlineo
force-pushed
the
1.2-fix-examples
branch
from
5b4bcf1 to
6297ea6
Compare
Removed some old stale files in the resources folder There is an infinite loop in `session._begin_tx` method where a tx is created before a conn is really established. As a result, if the server went down before the session is closed, then in `session._close`, the session will see a tx should be rolled back and blocks infinitly on `tx._roll_back.consume` as no record will ever return. This PR makes sure that in `session._begin_tx`, a tx is created after a conn is established.
zhenlineo
force-pushed
the
1.2-fix-examples
branch
from
8eace76 to
da58ba2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.