Fix socket timeouts #1227
Merged
Fix socket timeouts #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Fix connection hint timeout The driver may receive a configuration hint from the server during connection setup. The hint is a timeout: if the driver is waiting for a response from the server but has not heard back within the timeout window, the driver shall assume the connection is dead. The server can send `NOOP` ping messages to reset the timer ticking on the client-side. The driver applied this hint to both reads and writes. This PR changes it so that the hint, as intended, only applies to read operations on connections. ## New write timeout configuraiton option To avoid the driver hanging indefinitely on write operations, a new driver-level configuration option `connection_write_timeout`, which defaults to `30 seconds` is introduced. As the name suggests, this timeout is applied to all write operations on connections.
robsdedude
force-pushed
the
feat/tcp-write-timeout
branch
from
eddc877 to
c97a056
Compare
StephenCathcart
approved these changes
Jul 28, 2025
Contributor
StephenCathcart
left a comment
StephenCathcart
left a comment
There was a problem hiding this comment.
👍 looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix connection hint timeout
The driver may receive a configuration hint from the server during connection setup. The hint is a timeout: if the driver is waiting for a response from the server but has not heard back within the timeout window, the driver shall assume the connection is dead. The server can send
NOOPping messages to reset the timer ticking on the client-side.The driver applied this hint to both reads and writes. This PR changes it so that the hint, as intended, only applies to read operations on connections.
New write timeout configuraiton option
To avoid the driver hanging indefinitely on write operations, a new driver-level configuration option
connection_write_timeout, which defaults to30 secondsis introduced. As the name suggests, this timeout is applied to all write operations on connections.