Skip to content

Remove Record.__getslice__ #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Remove Record.__getslice__ #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7cc467
Remove `Record.__getslice__`
robsdedude May 14, 2025
304ed54
Merge branch '6.x' into remove-record-getslice
robsdedude May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ See also https://github.com/neo4j/neo4j-python-driver/wiki for a full changelog.
errors.
- It is now the same error raised as when trying to start an explicit transaction while another explicit transaction
is already active.
- Remove deprecated `Record.__getslice__`. This magic method has been removed in Python 3.0.
If you were calling it directly, please use `Record.__getitem__(slice(...))` or simply `record[...]` instead.


## Version 5.28
Expand Down
15 changes: 0 additions & 15 deletions src/neo4j/_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,6 @@

from ._codec.hydration import BrokenHydrationObject
from ._conf import iter_items


if t.TYPE_CHECKING:
from typing_extensions import deprecated
else:
from ._meta import deprecated

from ._spatial import Point
from .exceptions import BrokenRecordError
from .graph import (
Expand Down Expand Up @@ -150,14 +143,6 @@ def __getitem__( # type: ignore[override]
else:
return self._super_getitem_single(index)

# TODO: 6.0 - remove
@deprecated("This method is deprecated and will be removed in the future.")
def __getslice__(self, start, stop): # noqa: PLW3201 will be removed
key = slice(start, stop)
keys = self.__keys[key]
values = tuple(self)[key]
return self.__class__(zip(keys, values, strict=True))

def get(self, key: str, default: object = None) -> t.Any:
"""
Obtain a value from the record by key.
Expand Down