Skip to content

Conversation

@robsdedude
Copy link
Member

The example used an old version of ExpiringAuth. Before version 5.9, ExpiringAuth accepted an expires_in parameter, which then was changed to expires_at while expires_in was moved to be a convenience method on ExpiringAuth instances.

However, the example code in AsyncAuthManagers.basic was not adjusted.

The example used an old version of `ExpiringAuth`. Before version 5.9,
`ExpiringAuth` accepted an `expires_in` parameter, which then was changed to
`expires_at` while `expires_in` was moved to be a convenience method on
`ExpiringAuth` instances.

However, the example code in `AsyncAuthManagers.basic` was not adjusted.
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robsdedude robsdedude merged commit 6543363 into neo4j:5.0 Oct 31, 2024
20 checks passed
@robsdedude robsdedude deleted the api-docs/fix-expiring-auth-example branch October 31, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants