Temporal types: improvements around tzinfo #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Docs: clearly state that our temporal types are meant to be paired with `pytz` and `pytz` only. * Code: improve compatibility of `DateTime.now`, `.dst`, and `.tzname` with other `tzinfo` implementations. **IMPORTANT**: those implementations are still not, and will not be fully supported.
RichardIrons-neo4j
approved these changes
Oct 16, 2024
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Oct 23, 2024
* Docs:
* clearly state that our temporal types are meant to be paired with `pytz`
and `pytz` only.
* remove outdated remark on time zone support
* Code: improve compatibility of `DateTime.now`, `.dst`, and `.tzname` with
other `tzinfo` implementations.
**IMPORTANT**: those implementations are still not, and will not be fully
supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytzandpytzonly.DateTime.now,.dst, and.tznamewith othertzinfoimplementations.IMPORTANT: those implementations are still not, and will not be fully supported.
Closes: #1103