Skip to content

Conversation

@robsdedude
Copy link
Member

@robsdedude robsdedude commented Oct 9, 2024

  • Refactor bolt socket
    Move handshake and connect method that can be automatically un-async-ed for less code duplication.
  • minor tox config improvements: enable warning as error on py3.13, too
  • Drop (undocumented) support for Bolt 4.1
  • Tests: fix event loop shutdown for Python <= 3.8

Depends on:

Move handshake and connect method that can be automatically un-async-ed for
less code duplication.
@robsdedude robsdedude marked this pull request as ready for review February 3, 2025 10:09
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯

@robsdedude robsdedude changed the title Bolt Handshake v2 Bolt Handshake Manifest v1 Feb 4, 2025
@robsdedude robsdedude enabled auto-merge (squash) February 4, 2025 09:02
@robsdedude robsdedude merged commit 12ffd00 into neo4j:5.0 Feb 4, 2025
20 checks passed
@robsdedude robsdedude deleted the bolt-handshake-v2 branch February 4, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants