Fix bugs in neo4j.time.DateTime handling #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
fix-datetime-handling
branch
3 times, most recently
from
1db9898 to
0ea8313
Compare
* Fix `DateTime` +/- `Duration` computation being wildly off by considering the days of the `DateTime` since UNIX epoch twice. * Fix `Result.to_df` not correctly converting `DateTime`s with `tzinfo` if `parse_dates=True` is passed in. * Fix `DateTime.__ne__` (inequality operator) always falling back to `object.__ne__` (comparison by `id`).
robsdedude
force-pushed
the
fix-datetime-handling
branch
from
0ea8313 to
69336bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTime+/-Durationcomputation being wildly off by considering the days of theDateTimesince UNIX epoch twice.Result.to_dfnot correctly convertingDateTimes withtzinfoifparse_dates=Trueis passed in.DateTime.__ne__(inequality operator) always falling back toobject.__ne__(comparison byid).