Skip to content

Tests: Python 3.12 enable warnings as errors #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Tests: Python 3.12 enable warnings as errors #1027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1687a3b
Tests: Python 3.12 enable warnings as errors
robsdedude Mar 6, 2024
6921689
Merge branch '5.0' into py12-enable-warnings-as-errors
robsdedude Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions testkit/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,6 @@ def get_python_version():

def run_python(args, env=None, warning_as_error=True):
cmd = [TEST_BACKEND_VERSION, "-u"]
if get_python_version() >= (3, 12):
# Ignore warnings for Python 3.12 for now
# https://github.com/dateutil/dateutil/issues/1284 needs to be released
# and propagate through our dependency graph
warning_as_error = False
if warning_as_error:
cmd += ["-W", "error"]
cmd += list(args)
Expand Down
6 changes: 1 addition & 5 deletions testkitbackend/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,7 @@ async def main():


if __name__ == "__main__":
if sys.version_info < (3, 12):
# Ignore warnings for Python 3.12 for now
# https://github.com/dateutil/dateutil/issues/1284 needs to be released
# and propagate through our dependency graph
warnings.simplefilter("error")
warnings.simplefilter("error")
if len(sys.argv) == 2 and sys.argv[1].lower().strip() == "async":
async_main()
else:
Expand Down
6 changes: 1 addition & 5 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,8 @@ passenv = TEST_NEO4J_*
deps = -r requirements-dev.txt
setenv = COVERAGE_FILE={envdir}/.coverage
usedevelop = true
# Ignore warnings for Python 3.12 for now
# https://github.com/dateutil/dateutil/issues/1284 needs to be released
# and propagate through our dependency graph
warnargs =
py{37,38,39,310,311}: -W error
py312:
py{37,38,39,310,311,312}: -W error
commands =
coverage erase
unit: coverage run -m pytest {[testenv]warnargs} -v {posargs} tests/unit
Expand Down