Introduce Driver.getServerInfo method
#878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the drivers unification initiative. The `Driver.verifyConnectivity` method was implemented in different ways accross the drivers with different returns value. For concistency and clarity about what the method does, the new behaviour of the `Driver.verifyConnectivy` is check the connectivity with all the readers available and then returns a resolve empty promise in case of success (the promise will be rejected, otherwise). The Server Info information was moved to the method `Driver.getSeverInfo` which verifies the connectivity and then returnt the `ServerInfo` of one of the read servers. For keeping the backwards compatibility, the `Driver.verifyConnectivity` was depreacted in this version and it should be replace with a version with `Promise<void>` as return value in the next major release. `Driver.getServerInfo` should be used instead if the client code needs server information.
bigmontz
force-pushed
the
5.0-get-server-info
branch
from
d62b190 to
0123eeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the drivers unification initiative.
The
Driver.verifyConnectivitymethod was implemented in different ways across the drivers with different returns value. For consistency and clarity about what the method does, the new behaviour of theDriver.verifyConnectivityis check the connectivity with all the readers available and then returns a resolve empty promise in case of success (the promise will be rejected, otherwise).The Server Info information was moved to the method
Driver.getSeverInfowhich verifies the connectivity and then returns theServerInfoof one of the read servers.For keeping the backwards compatibility, the
Driver.verifyConnectivitywas deprecated in this version and it should be replace with a version withPromise<void>as return value in the next major release.Driver.getServerInfoshould be used instead if the client code needs the server information.