Improvements to HTTP session #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.6-http-session-close
branch
4 times, most recently
from
8bf1a09 to
6b91c51
Compare
HTTP driver uses transactional Cypher endpoint instead of Bolt. It used to simply submit queries via `POST db/data/transaction/commit` in auto-commit mode. This made it impossible to cancel such queries because transaction id was not known. Canceling is needed in `Session#close()` to terminate all ongoing queries and transactions. `Session#close()` is used by neo4j-browser to terminate running queries. This commit makes `Session#close()` terminate all ongoing transactions and thus cancel all running queries. `Session#run()` now does not submit query directly via `POST db/data/transaction/commit`. Instead, it first starts a transaction via `POST db/data/transaction` and gets id of the newly started transaction. Then a query is submitted via `POST db/data/transaction/XXX` where `XXX` is the transaction id. After a successful query, separate commit request is issued via `POST db/data/transaction/XXX/commit`. After a failed query, rollback is issued via `DELETE db/data/transaction/XXX`. Transaction id is thus known during the query execution and can be used by `Session#close()` to rollback the transaction via `DELETE db/data/transaction/XXX`.
This commit makes experimental HTTP driver able to receive spatial 2D and 3D points and return them as `Point` objects in records. Note that no metadata is returned by the REST endpoint for nested points (in lists or maps) so they will not be converted to `Point` objects.
There currently exists no way for the REST endpoint to accept spatial and temporal types as query parameters. This commit makes driver fail fast so that given spatial or temporal objects are not misinterpreted as maps.
All temporal values are exposed as ISO strings, not temporal objects, as with bolt.
This will rollback all open transactions and cancel running queries.
lutovich
force-pushed
the
1.6-http-session-close
branch
from
6b91c51 to
91b4e6c
Compare
ali-ince
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session#close()terminates ongoing transactions/queries to align with RESET message in Bolt