Skip to content

Better logging for Driver creation #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2018
Merged

Better logging for Driver creation #486

merged 1 commit into from
Apr 16, 2018

Conversation

@technige
Copy link
Contributor

@technige technige commented Apr 13, 2018

When creating multiple Driver objects, the log detail is unhelpful:

Apr 13, 2018 3:28:58 PM org.neo4j.driver.internal.logging.JULogger info
INFO: Driver instance org.neo4j.driver.internal.InternalDriver@1ed4004b created
Apr 13, 2018 3:28:58 PM org.neo4j.driver.internal.logging.JULogger info
INFO: Driver instance org.neo4j.driver.internal.InternalDriver@59e5ddf created

This change adds extra detail (Direct/Routing and server address) but requires moving the log.info calls to where the address is available.

@lutovich lutovich merged commit dda3e89 into neo4j:1.6 Apr 16, 2018
@technige technige deleted the 1.6-driver-logging branch April 16, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lutovich lutovich lutovich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@technige @lutovich