Upgrade and shade netty #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.5-shade-netty
branch
2 times, most recently
from
cd9d9e9 to
92fe543
Compare
Make driver depend on netty-handler instead of netty-all because it is much smaller and contains only features we use. Also netty version is upgraded from 4.1.15 to 4.1.16. Introduced shade plugin to pack netty dependency inside driver jar. Shaded classes will be relocated to `org.neo4j.driver.internal.shaded` package. This means driver will not bring netty as it's transitive dependency and has it's private copy of netty classes removing the possibility of dependency conflicts.
lutovich
force-pushed
the
1.5-shade-netty
branch
from
92fe543 to
f1cc0ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make driver depend on netty-handler instead of netty-all because it is much smaller and contains only features we use. Also netty version is upgraded from 4.1.15 to 4.1.16.
Introduced shade plugin to pack netty dependency inside driver jar. Shaded classes will be relocated to
org.neo4j.driver.internal.shadedpackage. This means driver will not bring netty as it's transitive dependency and has it's private copy of netty classes removing the possibility of dependency conflicts.