Perform writes fully in event loop #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NettyConnection` is the abstraction over netty channel that allows us to write RUN, PULL_ALL and other messages. Currently write consists of two steps: (1) enqueue a response handler (2) perform actual write. Step (1) is executed in the caller thread and step (2) is always executed in the event loop thread (guaranteed by Netty). Step (1) involves modification of a non-synchronized `LinkedList` which is a problem. Later event loop thread will try to pop handlers from the same list meaning we access it from different threads. This commit make both (1) and (2) execute in the event loop to avoid synchronization issues. It basically makes sure `InboundMessageDispatcher` is only accessed by the event loop. Also removed `ConcurrentSet` implementation in favour of the one existing in Netty.
lutovich
force-pushed
the
1.5-writes-in-evt-loop
branch
from
58213ed to
97e5f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NettyConnectionis the abstraction over netty channel that allows us to write RUN, PULL_ALL and other messages. Currently write consists of two steps: (1) enqueue a response handler (2) perform actual write. Step (1) is executed in the caller thread and step (2) is always executed in the event loop thread (guaranteed by Netty).Step (1) involves modification of a non-synchronized
LinkedListwhich is a problem. Later event loop thread will try to pop handlers from the same list meaning we access it from different threads.This PR make both (1) and (2) execute in the event loop to avoid synchronization issues. It basically makes sure
InboundMessageDispatcheris only accessed by the event loop.Also removed
ConcurrentSetimplementation in favour of the one existing in Netty.