Do not cache resolved inet address #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally driver always uses `BoltServerAddress` to represent host and port. These addresses are constructed from the initial driver URI and from routing procedure output in routing driver. Bolt address is only resolved to an `InetAddress` when new connection is established. Resolved `InetSocketAddress` was cached in `BoltServerAddress` which caused problems when corresponding DNS record changed. Driver would then still try to connect to a cached stale `InetSocketAddress`. This commit makes resolution happen on every connection.
|
shall we fix it in 1.3/1.2? |
|
@zhenlineo I thought about fixing this only in 1.4 and doing 1.4.1 release to avoid touching previous branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally driver always uses
BoltServerAddressto represent host and port. These addresses are constructed from the initial driver URI and from routing procedure output in routing driver. Bolt address is only resolved to anInetAddresswhen new connection is established.Resolved
InetSocketAddresswas cached inBoltServerAddresswhich caused problems when corresponding DNS record changed. Driver would then still try to connect to a cached staleInetSocketAddress.This PR makes resolution happen on every connection.