Skip to content

Added empty principal to fix kerberos AuthToken #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Added empty principal to fix kerberos AuthToken #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions driver/src/main/java/org/neo4j/driver/v1/AuthTokens.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public static AuthToken kerberos( String base64EncodedTicket )
{
return new InternalAuthToken( parameters(
"scheme", "kerberos",
"principal", "", //This empty string is required for backwards compatibility.
"credentials", base64EncodedTicket).asMap( Values.ofValue() ) );
}

Expand Down
12 changes: 12 additions & 0 deletions driver/src/test/java/org/neo4j/driver/v1/AuthTokensTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,16 @@ public void customAuthParameters()
assertThat( map.get( "realm" ), equalTo( (Value) new StringValue( "baz" ) ) );
assertThat( map.get( "parameters" ), equalTo( (Value) new MapValue( expectedParameters ) ) );
}

@Test
public void basicKerberosAuthWithRealm()
{
InternalAuthToken token = (InternalAuthToken) AuthTokens.kerberos( "base64" );
Map<String,Value> map = token.toMap();

assertThat( map.size(), equalTo( 3 ) );
assertThat( map.get( "scheme" ), equalTo( (Value) new StringValue( "kerberos" ) ) );
assertThat( map.get( "principal" ), equalTo( (Value) new StringValue( "" ) ) );
assertThat( map.get( "credentials" ), equalTo( (Value) new StringValue( "base64" ) ) );
}
}