Add support of passing routing parameters via driver config #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
1.3-getServersV2
branch
from
5aaba5a to
54adf2e
Compare
zhenlineo
force-pushed
the
1.3-getServersV2
branch
from
54adf2e to
5421c71
Compare
lutovich
reviewed
Mar 16, 2017
Contributor
lutovich
left a comment
lutovich
left a comment
There was a problem hiding this comment.
@zhenlineo review round completed. Made couple comments.
| * limitations under the License. | ||
| */ | ||
| package org.neo4j.driver.v1.util; | ||
| package org.neo4j.driver.internal.cluster; |
Contributor
There was a problem hiding this comment.
Maybe org.neo4j.driver.internal.util?
| assertThat( e.getMessage(), | ||
| containsString( "Failed to call 'dbms.cluster.routing.getServers' procedure on server" ) ); | ||
| assertThat( e.getMessage(), containsString( "Failed to run " + | ||
| "'Statement{text='CALL dbms.cluster.routing.getServers', parameters={}}' on server." ) ); |
Contributor
There was a problem hiding this comment.
Imho user-facing message with Statement{ does not look pretty. Could we maybe concatenate a prettier message in GetServersProcedureClusterCompositionProvider instead of using default Statement#toString()?
Contributor
Author
There was a problem hiding this comment.
Let's improve it in another PR, I will merge this PR once it is green.
| runner.run( mock ); | ||
|
|
||
| // Then | ||
| assertThat( runner.procedureCalled().toString(), equalTo( |
Contributor
There was a problem hiding this comment.
Statement as a good #equals() method defined. I think it should be used for assertions instead of #toString().
added 2 commits
March 20, 2017 18:26
Renamed to `getRoutingTable` and `withRoutingContext`
zhenlineo
force-pushed
the
1.3-getServersV2
branch
from
be303fc to
870f892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
withRoutingParametersin driver Config for passing in getServersV2 parameters