Deprecate Session#reset() #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technige
reviewed
Mar 2, 2017
| * It is not useful when {@link Session} is used in a single thread because in this case {@link #close()} | ||
| * can be used. Since version 3.1, Neo4j database allows users to specify maximum transaction execution time and | ||
| * contains procedures to list and terminate running queries. These functions should be used instead of calling | ||
| * this method. <b>Will be removed in the next major release.</b> |
There was a problem hiding this comment.
Can you remove "Will be removed in the next major release". We'll deprecate to indicate this will not be ported to other drivers and should be avoided whenever possible but will not be replaced until the async API is introduced.
lutovich
force-pushed
the
1.2-deprecate-session-reset
branch
from
2d6cb3a to
bc68e85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #205.