Introduce new session instantiation methods #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/session-methods
branch
from
b372a08 to
516bfb1
Compare
These new methods provide a consistent API for creating different types of session APIs. Sample usage: ``` var synchronousSession = driver.session(Session.class); var asynchronousSession = driver.session(AsyncSession.class); var reactiveSession1 = driver.session(org.neo4j.driver.reactive.ReactiveSession.class); var reactiveSession2 = driver.session(org.neo4j.driver.reactivestreams.ReactiveSession.class); var reactiveSession3 = driver.session(org.neo4j.driver.reactive.RxSession.class); ``` The following methods have been deprecated: - `asyncSession` - `reactiveSession`
injectives
force-pushed
the
feature/session-methods
branch
from
516bfb1 to
19cc8e0
Compare
michael-simons
approved these changes
Oct 27, 2022
Contributor
michael-simons
left a comment
michael-simons
left a comment
There was a problem hiding this comment.
Conceptional great, haven’t look at the implementation. I think it reduces the spread out surface a lot without sacrificing functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new methods provide a consistent API for creating different types of session APIs.
Sample usage:
The following methods have been deprecated:
asyncSessionreactiveSession