Skip to content

Conversation

@Liam-Doodson
Copy link
Contributor

Description

Documentation on changes to the requires argument was only merged into the 4.0 branch and so they are currently un documented.

Complexity

Complexity: Low

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

⚠️ No Changeset found

Latest commit: 7008670

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@neo4j-team-graphql neo4j-team-graphql added the documentation Improvements or additions to documentation label Aug 17, 2023
@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Aug 17, 2023

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

darrellwarde
darrellwarde previously approved these changes Aug 18, 2023
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of suggestions. Also make sure this is in the docs repo!

Additionally, the docs section itself is out of date, for instance the directive definition: https://neo4j.com/docs/graphql-manual/4.0/custom-resolvers/#custom-resolver-directive

@Liam-Doodson
Copy link
Contributor Author

Yes this is all in the docs repo, I've just copied this from there! What's out of date on that link?

@darrellwarde
Copy link
Contributor

Yes this is all in the docs repo, I've just copied this from there! What's out of date on that link?

The directive definition still has requires as a List, unless this has been changed now and just not deployed?

@Liam-Doodson
Copy link
Contributor Author

Ah yes good spot! I'll raise a PR in the docs repo for that

@Liam-Doodson Liam-Doodson merged commit 1253720 into neo4j:dev Aug 18, 2023
@Liam-Doodson Liam-Doodson deleted the add-custom-resolver-requires-to-migration-guide branch August 18, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants