Skip to content

Conversation

@angrykoala
Copy link
Member

Description

Update cypher builder to 1.0.0, updating the escaping of labels and properties

@angrykoala angrykoala requested a review from darrellwarde July 13, 2023 08:55
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

🦋 Changeset detected

Latest commit: 145be0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@neo4j/graphql Major
@neo4j/graphql-toolbox Patch
@neo4j/graphql-ogm Major
neo-place Patch
apollo-subscriptions-server Patch
yoga-subscriptions-server Patch
@neo4j/graphql-plugin-subscriptions-amqp Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Jul 13, 2023

Thanks for the Neo4j GraphQL Toolbox updates.

The Neo4j GraphQL Toolbox has now been torn down - reopening this PR will republish it.

@neo4j-team-graphql
Copy link
Collaborator

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3403 3403 31 48 1134
aggregations.NestedAggregation 16553 16553 64 99 2174
aggregations.AggregationWithWhere 11979 11979 49 54 2174
aggregations.AggregationWhereWithinNestedRelationships 22116987 22116987 3077 3172 2008534
aggregations.AggregationWhereWithinNestedConnections 22116987 22116987 2687 2845 2008534
aggregations.NestedCountFromMovieToActors 9734 9734 60 45 2174
aggregations.NestedCountFromActorsToMovie 9937 9937 61 50 2174
aggregations.DeeplyNestedCount 13070331 13070331 4297 4672 2008534
batch-create.BatchCreate 4200 4200 127 160 600
batch-create.BatchCreateSmall 77 77 114 91 11
connect.createAndConnect 14424 14424 171 188 3003
connections.Connection 14082 14082 113 73 2174
connections.NestedConnection 45466 45468 107 137 4516
connections.ConnectionWithSort 3284 3284 60 69 1040
connections.ConnectionWithSortAndCypher 16325 16325 86 99 2174
create.SimpleMutation 7 7 51 85 1
cypher-directive.TopLevelMutationDirective 1135 1135 29 26 1134
delete.SimpleDelete 19401 19401 274 324 1040
delete.NestedDeleteInUpdate 19542 19542 222 171 2017
2925.SingleRelationshipFilter 6468 6468 59 45 1040
2925.NestedSingleRelationshipFilter 22900 22900 79 96 2174
2925.SingleRelationshipRequiredFilter 5201 5201 37 50 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 63 62 1040
query.SimpleQuery 3121 3121 21 22 1040
query.SimpleQueryWithRelationship 16162 16162 39 47 2174
query.QueryWhere 9697 9711 32 47 2161
query.SimpleQueryWithNestedWhere 9875 9889 53 74 2161
query.Nested 10096041 10096041 10304 10544 2008534
query.NestedWithFilter 10074401 10074401 10008 10520 2004000
query.OrFilterOnRelationships 40978 41712 178 234 1211
query.OrFilterOnRelationshipsAndNested 34624 35357 208 245 1211
query.QueryWithNestedIn 13297 13308 53 58 1182
query.NestedConnectionWhere 9834 9834 50 62 2174
query.DeeplyNestedConnectionWhere 9969 9969 75 85 2174
query.DeeplyNestedWithRelationshipFilters 19128 19170 123 156 1596
query.NestedWithRelationshipSingleFilters 3881 3881 151 193 1134
query.Fulltext 80 80 38 33 16
query.FulltextWithNestedQuery 587 587 45 45 84
sorting.SortMultipleTypes 3515 3515 69 70 1040
sorting.SortMultipleTypesWithCypherWithCypher 14552 14492 84 101 2174
sorting.SortOnNestedFields 14082 14082 44 63 2174
sorting.SortDeeplyNestedFields 43198 43198 90 99 4516
sorting.SortWithTopLevelCypher 16162 16162 47 52 2174
unions.SimpleUnionQuery 321 321 56 67 35
unions.SimpleUnionQueryWithMissingFields 293 293 91 70 35
unions.NestedUnion 410637 410637 377 455 33033
unions.NestedUnionWithMissingFields 384611 384611 277 306 33033
update.NestedUpdate 16143 16143 96 107 2002

Old Schema Generation: 38.564s
Schema Generation: 38.221s
Old Subgraph Schema Generation: 48.332s
Subgraph Schema Generation: 48.948s

Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flicked through all of the TCK test files, and all appears to be good!

@angrykoala angrykoala merged commit 3c24305 into neo4j:4.0.0 Jul 13, 2023
@angrykoala angrykoala deleted the update-cypher-builder branch July 13, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants