Skip to content

Conversation

@angrykoala
Copy link
Member

@angrykoala angrykoala commented Apr 26, 2023

Description

Adds escaping to relationships and fix some escaping edge cases in maps and projections

This PR also fix some conflicts with 4.0.0 after the addition on some escaping in the Cypher-Builder in dev

@angrykoala angrykoala requested a review from darrellwarde April 26, 2023 16:13
@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

🦋 Changeset detected

Latest commit: e1a7b26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@neo4j/graphql Major
@neo4j/cypher-builder Minor
@neo4j/graphql-toolbox Patch
@neo4j/graphql-ogm Major
neo-place Patch
apollo-subscriptions-server Patch
yoga-subscriptions-server Patch
@neo4j/graphql-plugin-subscriptions-amqp Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Apr 26, 2023

Thanks for the UI updates.

The UI has now been torn down - reopening this PR will republish it.

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Apr 26, 2023

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3403 3403 32 40 1134
aggregations.NestedAggregation 14551 14551 77 80 2174
aggregations.AggregationWithWhere 11979 11979 61 56 2174
aggregations.AggregationWhereWithinNestedRelationships 22116987 22116987 3132 2769 2008534
aggregations.AggregationWhereWithinNestedConnections 22116987 22116987 2728 2806 2008534
aggregations.NestedCountFromMovieToActors 9734 9734 39 44 2174
aggregations.NestedCountFromActorsToMovie 9937 9937 40 51 2174
aggregations.DeeplyNestedCount 13070331 13070331 4510 4385 2008534
batch-create.BatchCreate 4200 4200 130 140 600
connect.createAndConnect 14424 14424 169 205 3003
connections.Connection 14082 14082 103 69 2174
connections.NestedConnection 41462 41462 109 154 4516
connections.ConnectionWithSort 2282 2282 61 73 1040
connections.ConnectionWithSortAndCypher 15323 15323 100 128 2174
create.SimpleMutation 7 7 53 60 1
cypher-directive.TopLevelMutationDirective 1135 1135 37 27 1134
delete.SimpleDelete 19401 19401 258 245 1040
delete.NestedDeleteInUpdate 18196 18196 257 235 1179
2925.SingleRelationshipFilter 6468 6468 66 71 1040
2925.NestedSingleRelationshipFilter 22900 22900 77 159 2174
2925.SingleRelationshipRequiredFilter 3450 3450 25 55 1134
2925.NestedSingleRelationshipRequiredFilter 9383 9383 47 63 1040
query.SimpleQuery 15160 15160 55 70 2174
query.QueryWhere 9685 9712 35 49 2158
query.SimpleQueryWithNestedWhere 9863 9890 53 59 2158
query.Nested 10092037 10092037 9840 11011 2008534
query.NestedWithFilter 40401 40401 101 104 4511
query.OrFilterOnRelationships 43814 42592 194 193 2073
query.OrFilterOnRelationshipsAndNested 37458 36148 322 247 2073
query.QueryWithNestedIn 13776 13396 59 69 1343
query.NestedConnectionWhere 9834 9834 54 85 2174
query.DeeplyNestedConnectionWhere 9928 9896 72 89 2174
query.DeeplyNestedWithRelationshipFilters 19092 19146 123 146 1580
query.NestedWithRelationshipSingleFilters 3732 3732 152 259 1134
query.Fulltext 80 80 35 46 16
query.FulltextWithNestedQuery 587 587 45 47 84
sorting.SortMultipleTypes 2513 2513 70 70 1040
sorting.SortMultipleTypesWithCypherWithCypher 14558 14515 109 101 2174
sorting.SortOnNestedFields 14082 14082 90 51 2174
sorting.SortDeeplyNestedFields 42196 42196 194 120 4516
sorting.SortWithTopLevelCypher 15160 15160 63 61 2174
unions.SimpleUnionQuery 321 321 63 75 35
unions.SimpleUnionQueryWithMissingFields 293 293 63 63 35
unions.NestedUnion 410637 410637 293 316 33033
unions.NestedUnionWithMissingFields 384611 384611 283 324 33033
update.NestedUpdate 2119 2119 69 114 1040

Old Schema Generation: 34.159s
Schema Generation: 33.342s
Old Subgraph Schema Generation: 47.459s
Subgraph Schema Generation: 46.371s

Copy link
Contributor

@mjfwebb mjfwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@angrykoala angrykoala merged commit f224da6 into neo4j:4.0.0 Apr 27, 2023
@angrykoala angrykoala deleted the escape-properties-and-relationships branch April 27, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants