Remove config.callbacks

[mjfwebb]

Description

This PR remove config.callbacks as it has been deprecated and replaced with features.populatedBy.callbacks.

Complexity

Low

[changeset-bot]

🦋 Changeset detected

Latest commit: 0d93a6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@neo4j/graphql	Major
@neo4j/graphql-toolbox	Patch
@neo4j/graphql-ogm	Major
neo-place	Patch
neo-push-server	Patch
apollo-suscriptions-server	Patch
yoga-subscriptions-server	Patch
@neo4j/graphql-plugin-subscriptions-amqp	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-advanced-security]

You have successfully added a new CodeQL configuration .github/workflows/pull-requests.yml:code-scanning. As part of the setup process, we have scanned this repository and found 6 existing alerts. Please check the repository Security tab to see all alerts.

[darrellwarde]

There's I think a nice opportunity to simplify makeAugmentedSchema arguments here - remove callbacks, it's already there inside the features object. Access it from there wherever it's needed.

[neo4j-team-graphql]

Performance Report

No Performance Changes

Show Full Table

name	dbHits	old dbHits	time (ms)	old time (ms)	maxRows
aggregations.TopLevelAggregate	3403	3403	33	44	1134
aggregations.NestedAggregation	14551	14551	67	125	2174
aggregations.AggregationWithWhere	11979	11979	41	63	2174
aggregations.AggregationWhereWithinNestedRelationships	22116987	22116987	3194	3103	2008534
aggregations.AggregationWhereWithinNestedConnections	22116987	22116987	2803	2710	2008534
aggregations.NestedCountFromMovieToActors	9734	9734	44	54	2174
aggregations.NestedCountFromActorsToMovie	9937	9937	47	70	2174
aggregations.DeeplyNestedCount	13070329	13070331	4226	4281	2008534
batch-create.BatchCreate	4200	4200	234	151	600
connect.createAndConnect	14424	14424	159	248	3003
connections.Connection	14082	14082	62	66	2174
connections.NestedConnection	41462	41462	126	229	4516
connections.ConnectionWithSort	2282	2282	63	67	1040
connections.ConnectionWithSortAndCypher	15323	15323	101	103	2174
create.SimpleMutation	7	7	59	66	1
cypher-directive.TopLevelMutationDirective	1135	1135	47	37	1134
delete.SimpleDelete	19401	19401	245	273	1040
delete.NestedDeleteInUpdate	18540	18540	217	210	1179
2925.SingleRelationshipFilter	6468	6468	126	39	1040
2925.NestedSingleRelationshipFilter	22900	22900	96	90	2174
2925.SingleRelationshipRequiredFilter	3450	3450	24	29	1134
2925.NestedSingleRelationshipRequiredFilter	9383	9383	51	49	1040
query.SimpleQuery	15160	15160	58	48	2174
query.QueryWhere	9699	9716	31	47	2163
query.SimpleQueryWithNestedWhere	9877	9894	45	75	2163
query.Nested	10092037	10092037	9816	10667	2008534
query.NestedWithFilter	40401	40401	115	116	4511
query.OrFilterOnRelationships	42050	42631	152	193	1388
query.OrFilterOnRelationshipsAndNested	35145	35709	177	284	1388
query.QueryWithNestedIn	13822	14372	53	61	1358
query.NestedConnectionWhere	9834	9834	51	56	2174
query.DeeplyNestedConnectionWhere	9991	9988	65	78	2174
query.DeeplyNestedWithRelationshipFilters	19194	19248	115	167	1618
query.NestedWithRelationshipSingleFilters	3024400	3024400	689	611	1003942
query.Fulltext	96	96	43	27	16
query.FulltextWithNestedQuery	587	587	51	44	84
sorting.SortMultipleTypes	2513	2513	61	73	1040
sorting.SortMultipleTypesWithCypherWithCypher	14449	14489	86	183	2174
sorting.SortOnNestedFields	14082	14082	47	108	2174
sorting.SortDeeplyNestedFields	42196	42196	87	104	4516
sorting.SortWithTopLevelCypher	15160	15160	51	56	2174
unions.SimpleUnionQuery	321	321	58	73	35
unions.SimpleUnionQueryWithMissingFields	293	293	60	65	35
unions.NestedUnion	410637	410637	301	326	33033
unions.NestedUnionWithMissingFields	384611	384611	278	312	33033
update.NestedUpdate	2119	2119	82	61	1040

Old Schema Generation: 27.871s
Schema Generation: 29.482s
Old Subgraph Schema Generation: 41.551s
Subgraph Schema Generation: 43.845s

[darrellwarde]

LGTM!