Remove callback directive

[mjfwebb]

Description

This PR removes the deprecated @callback directive. Both the code itself and the documentation for the directive have been removed.

Tests using @callback have been updated to use @populatedBy.

Complexity

Low

[changeset-bot]

🦋 Changeset detected

Latest commit: c99941b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@neo4j/graphql	Major
@neo4j/graphql-toolbox	Patch
@neo4j/graphql-ogm	Major
neo-place	Patch
neo-push-server	Patch
apollo-suscriptions-server	Patch
yoga-subscriptions-server	Patch
@neo4j/graphql-plugin-subscriptions-amqp	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-advanced-security]

You have successfully added a new CodeQL configuration .github/workflows/pull-requests.yml:code-scanning. As part of the setup process, we have scanned this repository and found 6 existing alerts. Please check the repository Security tab to see all alerts.

[neo4j-team-graphql]

Performance Report

No Performance Changes

Show Full Table

name	dbHits	old dbHits	time (ms)	old time (ms)	maxRows
aggregations.TopLevelAggregate	3403	3403	46	43	1134
aggregations.NestedAggregation	14551	14551	89	114	2174
aggregations.AggregationWithWhere	11979	11979	55	76	2174
aggregations.AggregationWhereWithinNestedRelationships	22116987	22116987	3068	3204	2008534
aggregations.AggregationWhereWithinNestedConnections	22116987	22116987	2736	2767	2008534
aggregations.NestedCountFromMovieToActors	9734	9734	68	58	2174
aggregations.NestedCountFromActorsToMovie	9937	9937	62	90	2174
aggregations.DeeplyNestedCount	13070345	13070331	4354	4625	2008534
batch-create.BatchCreate	4200	4200	150	171	600
connect.createAndConnect	14424	14424	266	220	3003
connections.Connection	14082	14082	79	76	2174
connections.NestedConnection	41462	41462	111	138	4516
connections.ConnectionWithSort	2282	2282	69	82	1040
connections.ConnectionWithSortAndCypher	15323	15323	88	141	2174
create.SimpleMutation	7	7	55	69	1
cypher-directive.TopLevelMutationDirective	1135	1135	26	47	1134
delete.SimpleDelete	19401	19401	262	375	1040
delete.NestedDeleteInUpdate	18196	18196	155	269	1179
2925.SingleRelationshipFilter	6468	6468	37	56	1040
query.SimpleQuery	15160	15160	70	75	2174
query.QueryWhere	9713	9700	42	57	2166
query.SimpleQueryWithNestedWhere	9891	9878	57	81	2166
query.Nested	10092037	10092037	10536	11148	2008534
query.NestedWithFilter	40401	40401	138	134	4511
query.OrFilterOnRelationships	42755	41521	169	206	1738
query.OrFilterOnRelationshipsAndNested	36431	35229	206	225	1738
query.QueryWithNestedIn	13209	13454	57	116	1156
query.NestedConnectionWhere	9834	9834	54	88	2174
query.DeeplyNestedConnectionWhere	9884	9832	75	242	2174
query.DeeplyNestedWithRelationshipFilters	6343	6343	117	207	1134
query.NestedWithRelationshipSingleFilters	3024400	3024400	561	670	1003942
query.Fulltext	96	96	28	40	16
query.FulltextWithNestedQuery	587	587	77	61	84
sorting.SortMultipleTypes	2513	2513	107	85	1040
sorting.SortMultipleTypesWithCypherWithCypher	14469	14513	145	97	2174
sorting.SortOnNestedFields	14082	14082	96	66	2174
sorting.SortDeeplyNestedFields	42196	42196	107	128	4516
sorting.SortWithTopLevelCypher	15160	15160	50	56	2174
unions.SimpleUnionQuery	321	321	59	79	35
unions.SimpleUnionQueryWithMissingFields	293	293	57	80	35
unions.NestedUnion	410637	410637	329	469	33033
unions.NestedUnionWithMissingFields	384611	384611	317	343	33033
update.NestedUpdate	2119	2119	80	117	1040

Old Schema Generation: 33.674s
Schema Generation: 29.227s
Old Subgraph Schema Generation: 45.074s
Subgraph Schema Generation: 43.493s

[angrykoala]

The changes look good, just make sure to remove all the deprecated tests related to callback

[angrykoala]

This is part of the deperecated tests and it is updated already with populatedBy outside this folder. Now that callback is dropped we can safely removed the deprecated tests related to it

[mjfwebb]

Addressed in c99941b 👍