Escape relationship type strings #2955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2453604 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Performance ReportNo Performance Changes Show Full Table
Old Schema Generation: 41.218s |
Contributor
|
So, a couple of extra things we'll need here:
But I think this is a nice and clean enough solution until we improve schema generation! |
a-alle
reviewed
Mar 3, 2023
| callbacks?: Neo4jGraphQLCallbacks; | ||
| customResolvers?: IResolvers | Array<IResolvers>; | ||
| }) { | ||
| }): ObjectFields { |
Contributor
There was a problem hiding this comment.
can also remove the cast at the end now (as ObjectFields), right?
Contributor
Author
There was a problem hiding this comment.
Sadly not since it is potentially undefined due to obj.fields being potentially undefined.
|
|
||
| const direction = directionArg.value.value as "IN" | "OUT"; | ||
| const type = typeArg.value.value; | ||
| const type = `\`${typeArg.value.value}\``; |
Contributor
There was a problem hiding this comment.
can Cypher.utils.escapeLabel not be used here? I think this is the source of truth at the moment
Contributor
Author
There was a problem hiding this comment.
Oh, that's nice, thanks!
darrellwarde
requested changes
Mar 3, 2023
Contributor
darrellwarde
left a comment
darrellwarde
left a comment
There was a problem hiding this comment.
Outside of the code, just a couple of comments!
Co-authored-by: Darrell Warde <[email protected]>
Co-authored-by: Darrell Warde <[email protected]>
darrellwarde
approved these changes
Mar 6, 2023
Contributor
darrellwarde
left a comment
darrellwarde
left a comment
There was a problem hiding this comment.
LGTM, nice changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds escaping to relationship type strings.
There is a need for an unescaped version of the relationship type string so this is added as a new property
typeUnescapedThis PR also includes some small type and typo fixes that were in the periphery :)
Complexity
Low