Skip to content

Make the @relationshipProperties directive mandatory #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 28, 2023
Merged

Make the @relationshipProperties directive mandatory #2944

merged 16 commits into from
Feb 28, 2023

Conversation

@Liam-Doodson
Copy link
Contributor

@Liam-Doodson Liam-Doodson commented Feb 28, 2023

Description

Throw an error if the @relationshipProperties directive is not used on a relationship properties interface

Complexity

Complexity: Low

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d6acab2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql neo4j-team-graphql added documentation Improvements or additions to documentation graphql ogm introspector labels Feb 28, 2023
@Liam-Doodson Liam-Doodson changed the base branch from dev to 4.0.0 February 28, 2023 13:35
@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Feb 28, 2023 •
edited
Loading

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3403 3403 38 50 1134
aggregations.NestedAggregation 13514 13514 104 135 2174
aggregations.AggregationWithWhere 10942 10942 78 71 2174
aggregations.AggregationWhereWithinNestedRelationships 20101954 20101954 3223 3138 2008534
aggregations.AggregationWhereWithinNestedConnections 20101954 20101954 2936 2791 2008534
aggregations.NestedCountFromMovieToActors 8694 8694 81 60 2174
aggregations.NestedCountFromActorsToMovie 8900 8900 73 95 2174
aggregations.DeeplyNestedCount 12062310 12062298 4795 4466 2008534
batch-create.BatchCreate 3600 3600 98 135 600
connect.createAndConnect 12419 12419 350 278 3003
connections.Connection 13042 13042 172 230 2174
connections.NestedConnection 38231 38231 121 159 4516
connections.ConnectionWithSort 2277 2277 66 75 1040
connections.ConnectionWithSortAndCypher 14278 14278 91 150 2174
create.SimpleMutation 6 6 32 38 1
cypher-directive.TopLevelMutationDirective 1135 1135 67 47 1134
delete.SimpleDelete 18361 18361 308 258 1040
delete.NestedDeleteInUpdate 16779 16779 218 168 2040
query.SimpleQuery 14120 14120 210 121 2174
query.QueryWhere 8680 8656 38 47 2167
query.SimpleQueryWithNestedWhere 8851 8827 59 85 2167
query.Nested 10084290 10084290 10250 10573 2008534
query.NestedWithFilter 37172 37172 187 157 4511
query.OrFilterOnRelationships 36189 36289 166 185 1686
query.OrFilterOnRelationshipsAndNested 30237 30357 269 271 1686
query.QueryWithNestedIn 12142 12227 97 68 1149
query.NestedConnectionWhere 8794 8794 70 65 2174
query.DeeplyNestedConnectionWhere 8808 9054 96 134 2174
query.DeeplyNestedWithRelationshipFilters 6251 6251 123 319 1134
query.NestedWithRelationshipSingleFilters 3021189 3021189 675 773 1003942
query.Fulltext 96 96 27 32 16
query.FulltextWithNestedQuery 571 571 42 49 84
sorting.SortMultipleTypes 2493 2493 73 75 1040
sorting.SortMultipleTypesWithCypherWithCypher 13410 13452 103 103 2174
sorting.SortOnNestedFields 13042 13042 87 81 2174
sorting.SortDeeplyNestedFields 38965 38965 125 122 4516
sorting.SortWithTopLevelCypher 14120 14120 56 62 2174
unions.SimpleUnionQuery 321 321 61 69 35
unions.SimpleUnionQueryWithMissingFields 293 293 61 80 35
unions.NestedUnion 398553 398553 344 456 33033
unions.NestedUnionWithMissingFields 372527 372527 364 359 33033
update.NestedUpdate 2119 2119 55 60 1040

Old Schema Generation: 36.634s
Schema Generation: 35.345s

@Liam-Doodson Liam-Doodson marked this pull request as ready for review February 28, 2023 14:03
darrellwarde
darrellwarde approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, with nice documentation too!!

@Liam-Doodson Liam-Doodson merged commit 9602b83 into neo4j:4.0.0 Feb 28, 2023
@Liam-Doodson Liam-Doodson deleted the make-relationship-properties-directive-mandatory branch February 28, 2023 16:34
@neo4j-team-graphql neo4j-team-graphql mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrellwarde darrellwarde darrellwarde approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Liam-Doodson @neo4j-team-graphql @darrellwarde