Change custom resolver requires to a selection set #2922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ded2b68 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Performance ReportNo Performance Changes Show Full Table
Old Schema Generation: 28.985s |
Contributor
darrellwarde
left a comment
darrellwarde
left a comment
There was a problem hiding this comment.
I would make some changes as we discussed, but a few additional comments below! 🙂
…nge-customResolver-requires-to-a-selection-set
Co-authored-by: Darrell Warde <[email protected]>
Co-authored-by: Darrell Warde <[email protected]>
Contributor
darrellwarde
left a comment
darrellwarde
left a comment
There was a problem hiding this comment.
This looks much more on the right track, even if there is some duplication of functionality in parts! Just a couple of observations, but I think it's pretty much good to go.
darrellwarde
requested changes
Feb 28, 2023
Contributor
darrellwarde
left a comment
darrellwarde
left a comment
There was a problem hiding this comment.
Sorry again about the back and forth, but I hope you agree this is a slightly tidier solution. However, we should have conversation about validation in general, as it may be worthy of a revisit!
Co-authored-by: Darrell Warde <[email protected]>
darrellwarde
approved these changes
Feb 28, 2023
Contributor
darrellwarde
left a comment
darrellwarde
left a comment
There was a problem hiding this comment.
This looks good - I think just this final change needs applying!
Liam-Doodson
deleted the
change-customResolver-requires-to-a-selection-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #2722 and makes the
requireargument of the@customResolverdirective accept a graphql selection set.Complexity
Complexity: Medium
Issue
Closes #2481