Remove redundant arguments from constructor

[darrellwarde]

Description

Note

Please provide a description of the work completed in this PR below

Removes any arguments from IExecutableSchemaDefinition other than typeDefs and resolvers. This is to simplify the API, and to prepare the library for generating subgraph schemas which only accepts these two arguments.

If this turns out to be a blocking change, we can introduce functionality to fetch the augmented schema definition, so that users can use these additional arguments themselves.

This is the first PR into the new 4.0.0 branch, so we might need some patience on CI and on changesets!

Complexity

Note

Please provide an estimated complexity of this PR of either Low, Medium or High

Complexity: Low

[changeset-bot]

🦋 Changeset detected

Latest commit: 89ba59f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@neo4j/graphql	Major
@neo4j/graphql-ogm	Major
@neo4j/graphql-toolbox	Patch
neo-place	Patch
neo-push-server	Patch
apollo-suscriptions-server	Patch
yoga-subscriptions-server	Patch
@neo4j/graphql-plugin-subscriptions-amqp	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[neo4j-team-graphql]

Performance Report

No Performance Changes

Show Full Table

name	dbHits	old dbHits	time (ms)	old time (ms)	maxRows
aggregations.TopLevelAggregate	3403	3403	35	69	1134
aggregations.NestedAggregation	13514	13514	101	133	2174
aggregations.AggregationWithWhere	13210	13210	66	71	2174
aggregations.NestedCountFromMovieToActors	8694	8694	63	78	2174
aggregations.NestedCountFromActorsToMovie	8900	8900	88	82	2174
aggregations.DeeplyNestedCount	10054408	10054408	4978	4958	2008534
batch-create.BatchCreate	3600	3600	95	111	600
connect.createAndConnect	12419	12419	216	375	3003
connections.Connection	13042	13042	102	149	2174
connections.NestedConnection	33883	33883	159	130	4516
connections.ConnectionWithSort	2277	2277	67	68	1040
connections.ConnectionWithSortAndCypher	2277	2277	198	318	1040
create.SimpleMutation	6	6	31	36	1
cypher-directive.TopLevelCypherDirective	99525	99525	712	911	10168
cypher-directive.TopLevelCypherDirectiveWithColumnName	127994	127994	303	334	10168
delete.SimpleDelete	18361	18361	256	329	1040
delete.NestedDeleteInUpdate	16779	16779	255	333	2040
query.SimpleQuery	14120	14120	149	103	2174
query.QueryWhere	12994	12990	51	57	2166
query.SimpleQueryWithNestedWhere	13165	13161	52	58	2166
query.Nested	10084290	10084290	10005	10303	2008534
query.NestedWithFilter	38198	38198	194	138	4511
query.OrFilterOnRelationships	49536	53124	208	181	1357
query.OrFilterOnRelationshipsAndNested	36794	39828	200	247	1357
query.QueryWithNestedIn	15320	14619	58	63	1333
query.NestedConnectionWhere	13182	13182	54	64	2174
query.DeeplyNestedConnectionWhere	13337	13131	75	110	2174
query.DeeplyNestedWithRelationshipFilters	6913	6913	131	152	1134
query.DeeplyNestedWithRelationshipSingleFilters	15438	15438	93	112	2174
query.Fulltext	96	96	27	50	16
query.FulltextWithNestedQuery	571	571	47	46	84
sorting.SortMultipleTypes	2493	2493	63	69	1040
sorting.SortMultipleTypesWithCypherWithCypher	1418	1440	263	257	1040
sorting.SortOnNestedFields	13042	13042	151	86	2174
sorting.SortDeeplyNestedFields	38965	38965	227	182	4516
sorting.SortWithTopLevelCypher	2119	2119	137	192	1040
unions.SimpleUnionQuery	321	321	55	61	35
unions.SimpleUnionQueryWithMissingFields	293	293	54	130	35
unions.NestedUnion	398553	398553	300	515	33033
unions.NestedUnionWithMissingFields	372527	372527	337	296	33033

Old Schema Generation: 32.893s
Schema Generation: 31.118s

[tbwiss]

Looks good code-wise!