♻️ restructure addition docs (#145) #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ♻️ restructure addition docs * fix image for approved agent * there is no cog icon anymore, I think it was replaced with the table row's menu * just typos * repaired the link * Fix example service variable definitions * just typos * fixed broken link * Put the sentence " If CONFIG_INSTANCE_n_QUERY_LOG_PORT is not set, the feature is treated as disabled. The rest of NOM still works." to the description of CONFIG_INSTANCE_n_QUERY_LOG_PORT. Then moved "The location of server log configuration ..." including the IMPORTANT section to "Query log collection" on the page "Neo4j instance requirements" including adjusting the links from CONFIG_INSTANCE_n_LOG_CONFIG_PATH to point there. * it should be clear that the rest would work * Apply suggestions from code review Co-authored-by: Jessica Wright <[email protected]> * Apply suggestions from code review Co-authored-by: Jessica Wright <[email protected]> * editorial changes as suggested --------- Co-authored-by: Alexander Bouriakov <[email protected]> Co-authored-by: Jessica Wright <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ restructure addition docs
fix image for approved agent
there is no cog icon anymore, I think it was replaced with the table row's menu
just typos
repaired the link
Fix example service variable definitions
just typos
fixed broken link
Put the sentence " If CONFIG_INSTANCE_n_QUERY_LOG_PORT is not set, the feature is treated as disabled. The rest of NOM still works." to the description of CONFIG_INSTANCE_n_QUERY_LOG_PORT.
Then moved "The location of server log configuration ..." including the IMPORTANT section to "Query log collection" on the page "Neo4j instance requirements" including adjusting the links from CONFIG_INSTANCE_n_LOG_CONFIG_PATH to point there.
it should be clear that the rest would work
Apply suggestions from code review
Apply suggestions from code review
editorial changes as suggested
If you open a PR that needs to go into a current version, you need to cherry-pick your commit from dev over to the current version branch. Only then will the proper builds that generate html/pdf be run. But beware: Docs will be generated but not published automatically!