-
Notifications
You must be signed in to change notification settings - Fork 16
Docker first look with openssl, mTLS and agent self registration #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexicaWright
merged 15 commits into
neo4j:dev
from
alexnb:docker-first-look-with-mtls-and-self-registration
Sep 26, 2023
Merged
Docker first look with openssl, mTLS and agent self registration #158
AlexicaWright
merged 15 commits into
neo4j:dev
from
alexnb:docker-first-look-with-mtls-and-self-registration
Sep 26, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more, and we don't actually need to specify it.
✅ Deploy Preview for priceless-fermi-5883f3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Contributor
AlexicaWright
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editorial stuff.
Co-authored-by: Jessica Wright <[email protected]>
AlexicaWright
approved these changes
Sep 26, 2023
…tion # Conflicts: # modules/ROOT/pages/addition/kubernetes/sidecar.adoc
AlexicaWright
added a commit
to AlexicaWright/docs-ops-manager
that referenced
this pull request
Sep 26, 2023
…4j#158) * corrected docker compose syntax. Folder is not specified this way anymore, and we don't actually need to specify it. * made URL point to Ops Manager artifacts * made URL point to Ops Manager artifacts * improved description of GRPC_SERVER_SECURITY_CLIENT_AUTH * updated to use openssl for certificate creation, mTLS and agent self-registration * corrected values to be replaced * typos * typos * made more compact without loosing information * refer to docker first look guide for a concrete example to avoid duplication * moved reference to the example to be a note in front of the steps * updated to use 5.x Neo4j setting names * Apply suggestions from code review Co-authored-by: Jessica Wright <[email protected]> * updated to use 5.x Neo4j setting names --------- Co-authored-by: Jessica Wright <[email protected]>
AlexicaWright
added a commit
that referenced
this pull request
Sep 26, 2023
… (#167) * corrected docker compose syntax. Folder is not specified this way anymore, and we don't actually need to specify it. * made URL point to Ops Manager artifacts * made URL point to Ops Manager artifacts * improved description of GRPC_SERVER_SECURITY_CLIENT_AUTH * updated to use openssl for certificate creation, mTLS and agent self-registration * corrected values to be replaced * typos * typos * made more compact without loosing information * refer to docker first look guide for a concrete example to avoid duplication * moved reference to the example to be a note in front of the steps * updated to use 5.x Neo4j setting names * Apply suggestions from code review * updated to use 5.x Neo4j setting names --------- Co-authored-by: Alexander Bouriakov <[email protected]>
AlexicaWright
added a commit
to AlexicaWright/docs-ops-manager
that referenced
this pull request
Sep 26, 2023
…4j#158) * corrected docker compose syntax. Folder is not specified this way anymore, and we don't actually need to specify it. * made URL point to Ops Manager artifacts * made URL point to Ops Manager artifacts * improved description of GRPC_SERVER_SECURITY_CLIENT_AUTH * updated to use openssl for certificate creation, mTLS and agent self-registration * corrected values to be replaced * typos * typos * made more compact without loosing information * refer to docker first look guide for a concrete example to avoid duplication * moved reference to the example to be a note in front of the steps * updated to use 5.x Neo4j setting names * Apply suggestions from code review Co-authored-by: Jessica Wright <[email protected]> * updated to use 5.x Neo4j setting names --------- Co-authored-by: Jessica Wright <[email protected]>
AlexicaWright
added a commit
that referenced
this pull request
Sep 26, 2023
… (#168) * corrected docker compose syntax. Folder is not specified this way anymore, and we don't actually need to specify it. * made URL point to Ops Manager artifacts * made URL point to Ops Manager artifacts * improved description of GRPC_SERVER_SECURITY_CLIENT_AUTH * updated to use openssl for certificate creation, mTLS and agent self-registration * corrected values to be replaced * typos * typos * made more compact without loosing information * refer to docker first look guide for a concrete example to avoid duplication * moved reference to the example to be a note in front of the steps * updated to use 5.x Neo4j setting names * Apply suggestions from code review * updated to use 5.x Neo4j setting names --------- Co-authored-by: Alexander Bouriakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Summary of changes:
GRPC_SERVER_SECURITY_CLIENT_AUTHIf you open a PR that needs to go into a current version, you need to cherry-pick your commit from dev over to the current version branch. Only then will the proper builds that generate html/pdf be run. But beware: Docs will be generated but not published automatically!