Skip to content

Conversation

@lidiazuin
Copy link
Contributor

No description provided.

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Aug 24, 2023

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@lidiazuin lidiazuin marked this pull request as ready for review August 24, 2023 12:32
@darrellwarde
Copy link
Contributor

I've directly committed some suggestions here, figured it was easier to do that and revert if we don't like it rather than try to make a long comment describing my proposals!

We discussed putting all of the types and directives under a single "Type definitions" section, so I've tried that, with an index page also for types like you did with directives (love the table!).

I moved "Pagination" under "Queries and aggregations", we also discussed this change together.

As I say, we can revert this! Was meant to be one commit but ended up as 4 because I broke so many references! 🤦

What do you think? 🙂

@lidiazuin
Copy link
Contributor Author

I've directly committed some suggestions here, figured it was easier to do that and revert if we don't like it rather than try to make a long comment describing my proposals!

We discussed putting all of the types and directives under a single "Type definitions" section, so I've tried that, with an index page also for types like you did with directives (love the table!).

I moved "Pagination" under "Queries and aggregations", we also discussed this change together.

As I say, we can revert this! Was meant to be one commit but ended up as 4 because I broke so many references! 🤦

What do you think? 🙂

I think it's great! I wasn't sure about moving these pages to a higher level in the toc, so thank you for making the suggestion and the changes. :)) If there's nothing else, should we merge this one?

@darrellwarde darrellwarde merged commit 0efbf62 into neo4j:main Sep 1, 2023
@lidiazuin lidiazuin deleted the typedefinitions branch September 1, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants