-
Notifications
You must be signed in to change notification settings - Fork 15
Review of type definitions, directives and schema configuration sections #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Co-authored-by: Lidia Zuin <[email protected]>
Co-authored-by: Lidia Zuin <[email protected]>
Co-authored-by: Lidia Zuin <[email protected]>
Co-authored-by: Lidia Zuin <[email protected]>
Co-authored-by: Lidia Zuin <[email protected]>
|
I've directly committed some suggestions here, figured it was easier to do that and revert if we don't like it rather than try to make a long comment describing my proposals! We discussed putting all of the types and directives under a single "Type definitions" section, so I've tried that, with an index page also for types like you did with directives (love the table!). I moved "Pagination" under "Queries and aggregations", we also discussed this change together. As I say, we can revert this! Was meant to be one commit but ended up as 4 because I broke so many references! 🤦 What do you think? 🙂 |
I think it's great! I wasn't sure about moving these pages to a higher level in the toc, so thank you for making the suggestion and the changes. :)) If there's nothing else, should we merge this one? |
No description provided.