7th round of migration integration tests from Python #435
Conversation
robsdedude
force-pushed
the
python-integration-test-migration
branch
2 times, most recently
from
2087076 to
433c185
Compare
robsdedude
force-pushed
the
python-integration-test-migration
branch
from
433c185 to
541ee4e
Compare
Adding all timezones the Java driver is being tested with. Also adding a message for drivers to be able to opt out of testing of certain timezone IDs, should their OS not support it.
nutkit/backend/backend.py
Outdated
| self.send(req, hooks=hooks) | ||
| return self.receive(timeout, hooks=hooks) | ||
|
|
||
| def _check_system_support(self, type_, meta): |
There was a problem hiding this comment.
do you think it's worth introducing a general system check API now? what kind of checks do you foresee?
There was a problem hiding this comment.
Maybe ask JS if it knows the difference between 0.0 and 0 😐. I was just thinking that I don't want to introduce a message just for checking if a certain timezone is supported. That felt way to specific.
There was a problem hiding this comment.
I usually try to generalize something once I've got evidence of several specializations but YMMV
you could argue we can start with the simple, very specific timezone check and generalize it afterwards
that being said, such a generalization, if done at a later stage, would likely be a breaking change that would affect all testkit clients
There was a problem hiding this comment.
Yes. If it was just TestKit that's effected I wouldn't have done this. But as you say it affects the protocol and hence all backends. But I don't have a strong opinion on that. If you have, I can turn this into a specific message pair.
| @@ -0,0 +1,607 @@ | |||
| TZ_IDS = ( | |||
There was a problem hiding this comment.
how are we going to maintain this over time?
There was a problem hiding this comment.
I don't quite know. Any suggestions welcome. I mean this list should probably only ever get extended and never reduced.
robsdedude
force-pushed
the
python-integration-test-migration
branch
from
36662e9 to
b2f5a23
Compare
* Migrate temporal and spatial ITs to TestKit * Introduce RegExps for skipping TestKit tests * Add TestKit protocol messages for subtests PR in TestKit repo: neo4j-drivers/testkit#435
No description provided.