Remove pipe from replaced characters in callouts #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nvitucci
changed the title
Collaborator
|
The original intention was to strip lines by removing spaces from the end. Tabs where then also included and the regex for 'tabs or spaces' got a bit mangled. |
recrwplay
pushed a commit
that referenced
this pull request
Mar 6, 2024
recrwplay
pushed a commit
to recrwplay/docs-ui
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipe is excluded from content when copied through the Copy icon, causing it to be skipped when a code block like in the Kafka docs is copied.
This PR seems to fix this behaviour, but I would like to understand what was the rationale for exclusion before applying it.
This change was introduced in #204, but from the discussion I can't understand why the pipe was excluded as well.