Skip to content

[Snyk] Upgrade date-fns from 2.16.1 to 2.30.0 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade date-fns from 2.16.1 to 2.30.0 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 27 additions & 18 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"date-fns": "^2.16.1",
"date-fns": "^2.30.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The upgrade of date-fns from ^2.16.1 to ^2.30.0 is a significant jump, covering 24 minor versions. While this is within the same major version (v2), which generally aims for backward compatibility according to Semantic Versioning, such a large leap can introduce subtle breaking changes, deprecations, or behavioral differences that might affect your application.

Key considerations:

  • Changelog Review: Have you had a chance to review the date-fns changelogs for versions between 2.16.1 and 2.30.0? This could highlight any potential breaking changes, deprecated features, or significant updates that might impact how your application currently uses this library (e.g., the format function or other date/time manipulations).
  • Thorough Testing: It is critical to thoroughly test all parts of your application that rely on date-fns. This includes UI components displaying dates/times, any date-based logic, scheduling features, etc., to ensure this upgrade doesn't introduce regressions or unexpected behavior.

Given the potential impact, careful validation is highly recommended before merging.

"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-scripts": "4.0.1"
Expand Down