Always use "app" in dockle accept file path #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsf
changed the title
doshitan
approved these changes
Nov 10, 2025
Contributor
doshitan
left a comment
doshitan
left a comment
There was a problem hiding this comment.
Thank you! We should also rename template/{{app_name}}/.dockleconfig.jinja to template/{{app_name}}/.dockleconfig here since it doesn't need templated now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #252
Changes
Fixed path for settings.py in DOCKLE_ACCEPT_FILES.
Context for reviewers
Can be tested locally by exporting DOCKLE_ACCEPT_FILES before running dockle. Without this fix, the settings.py file in the app causes that check to fail. See the Dockerfile for where "app" is hardcoded in the path:
template-application-flask/template/{{app_name}}/Dockerfile
Line 77 in 5d4d40a
Testing
Tested in a generated app.