Generic Table Partial #182
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doshitan
force-pushed
the
doshitan/table-partial
branch
from
28f872c to
b545bcf
Compare
doshitan
force-pushed
the
doshitan/table-partial
branch
from
b545bcf to
496c7f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debated if this should be a view component/builder vs a partial. Ultimately could use probably use more general builders for handling all the USWDS tags, but this seemed reasonable to start.
Also considered renaming the partial to something like "simple_table", unless we anticipate building out more knobs. Doesn't need to be the last word in table construction, just something standard for quick views of a collection.
Testing
Dummy app cases page.
Before:
After: