Add test for stream mirror removal #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Casper Beyer <[email protected]>
caspervonb
force-pushed
the
test-stream-mirror-removal
branch
from
722051c to
cb25ac6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test case to verify that mirror configurations can be removed from JetStream streams, enabling "mirror promotion" functionality. This allows a mirror stream to become a standalone stream while retaining its messages.
- Adds test coverage for removing mirror configuration from streams
- Includes version check to skip test on NATS servers older than v2.12.0
- Validates that messages persist after mirror removal
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wallyqs
approved these changes
Nov 4, 2025
caspervonb
added a commit
that referenced
this pull request
Nov 14, 2025
Signed-off-by: Casper Beyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.