Fix filter_subject overriding filter_subjects #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
requested changes
Sep 16, 2025
Collaborator
caspervonb
left a comment
caspervonb
left a comment
There was a problem hiding this comment.
Thank you for your pull request. This seems sound, would need a test case however.
nickolaj-jepsen
force-pushed
the
fix-filter-subjects
branch
from
164fc78 to
5548f26
Compare
nickolaj-jepsen
force-pushed
the
fix-filter-subjects
branch
from
5548f26 to
e5eb243
Compare
Contributor
Author
|
Hi @caspervonb, thanks for the review, I've added a test case for both the push and pull based subscriber. Let me know if you want any additional tests 🙂 |
caspervonb
approved these changes
Sep 23, 2025
Signed-off-by: Mark Jan van Kampen <[email protected]>
caspervonb
changed the title
Jarema
pushed a commit
that referenced
this pull request
Oct 30, 2025
Signed-off-by: Mark Jan van Kampen <[email protected]>
caspervonb
pushed a commit
that referenced
this pull request
Nov 14, 2025
Signed-off-by: Mark Jan van Kampen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids setting filter_subject if filter_subjects is set, this avoids the server throwing this error when creating a consumer: "consumer cannot have both FilterSubject and FilterSubjects specified"
fixes: #710