-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add new properties #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
networkfusion
wants to merge
14
commits into
nanoframework:main
Choose a base branch
from
networkfusion:networkfusion-add-new-parameters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add new properties #128
networkfusion
wants to merge
14
commits into
nanoframework:main
from
networkfusion:networkfusion-add-new-parameters
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add update interval
Improve documentation.
so we dont break the existing lib.
Co-authored-by: José Simões <[email protected]>
Co-authored-by: José Simões <[email protected]>
Co-authored-by: José Simões <[email protected]>
Co-authored-by: José Simões <[email protected]>
Co-authored-by: José Simões <[email protected]>
Co-authored-by: José Simões <[email protected]>
Co-authored-by: José Simões <[email protected]>
UpdateInterval StartupDelay RetryPeriod
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Bump version.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








Description
Changes the class type to
staticas it is!Adds commented out properties for other improvements.
Motivation and Context
The current implementation was missing properties for UpdateInterval, StartupDelay, RetryPeriod which makes controlling the SNTP service hard. This PR adds them.
(Requires changes to the unmanaged implementation).
How Has This Been Tested?
Screenshots
Types of changes
Checklist: