Skip to content

Implement layout.barbase (closes issue 475) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Implement layout.barbase (closes issue 475) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
03e5072
bar: use descriptive variable names
n-riesco Oct 6, 2016
bbdc385
bar: convert closure into function
n-riesco Oct 7, 2016
7b14fcd
bar: refactor code to group bars
n-riesco Oct 7, 2016
fe66e3c
bar: rename `barpositions` to `setOffsetAndWidth`
n-riesco Oct 10, 2016
d422f67
bar: refactor code into function `setBaseAndSize`
n-riesco Oct 10, 2016
97da55b
bar: replace t.dbar with t.bargroupwidth
n-riesco Oct 12, 2016
93ca66e
bar: Move code for `overlay` mode into a function
n-riesco Oct 12, 2016
80fdfbd
bar: refactor code into functions for each barmode
n-riesco Oct 13, 2016
3b87e85
bar: use Sieve to stack bars in setBaseAndSize
n-riesco Oct 14, 2016
a7ca755
bar: add functions stackBars and normalizeBars
n-riesco Oct 14, 2016
b5f5bef
bar: Implement layout.barbase
n-riesco Oct 17, 2016
c667e78
test: layout.barbase
n-riesco Oct 17, 2016
4bd88a7
test: Add mock with layout.barbase
n-riesco Oct 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/traces/bar/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {
xa = pointData.xa,
ya = pointData.ya,
barDelta = (hovermode === 'closest') ?
t.barwidth / 2 : t.dbar * (1 - xa._gd._fullLayout.bargap) / 2,
t.barwidth / 2 :
t.bargroupwidth,
barPos;

if(hovermode !== 'closest') barPos = function(di) { return di.p; };
Expand Down
6 changes: 6 additions & 0 deletions src/traces/bar/layout_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@


module.exports = {
barbase: {
valType: 'number',
dflt: 0,
role: 'style',
description: 'Sets where the bar base is drawn (in axis units).'
},
barmode: {
valType: 'enumerated',
values: ['stack', 'group', 'overlay', 'relative'],
Expand Down
2 changes: 2 additions & 0 deletions src/traces/bar/layout_defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ module.exports = function(layoutIn, layoutOut, fullData) {

if(!hasBars) return;

coerce('barbase');

var mode = coerce('barmode');
if(mode !== 'overlay') coerce('barnorm');

Expand Down
Loading