query.sql unformatted until query sent to connection

[layerzerolabs]

Hi,

In the Readme it says that after running a prepared statement you can get the full SQL with query.sql. However I am finding that it returns the string from the prepared statement directly, containing the question mark, rather than replacing it with the parameters.

Regards

Naomi

[dougwilson]

Can you show me an example of what you are doing, please? This library doesn't support prepared statements, though it does support doing replacements that look similar to them.

[layerzerolabs]

Wow, quick reply! I'm using that cool thing where you can insert a full object. Here's the relevant code:

var query = pool.query('insert into todmorden set ?', reading, callback);
console.log(query.sql);

The insert works perfectly, inserting a row with all the fields from the reading object. However what gets logged to the console is "insert into todmorden set ?"

It doesn't affect the functionality, but just makes it harder to debug.

[layerzerolabs]

Sorry, didn't mean to close the issue! Butter fingers!

[dougwilson]

Ah. It's possible it's an issue with using pool.query vs connection.query. If you can before I get to it, let me know if connection.query works or not.

[dougwilson]

Ok, I see the issue: query.sql is not actually transformed until the query is sent to the database. We may want to actually transform it right away.