Skip to content

parse, _typeCast should not be enumerable #895

@SystemParadox

Description

@SystemParadox

Result sets from node-mysql do not work with chai's assert.deepEqual function:

var assert = require('chai').assert;
db.query("SELECT 1", function (err, result, fields) {
    assert.deepEqual(result, [{ '1': 1 }]); // fails
    assert.deepEqual(result, [{ '1': 1, _typeCast: result[0]._typeCast, parse: result[0].parse }]); // works
});

The _typeCast and parse properties are enumerable, so chai uses them in the comparison. Please could these be changed to non-enumerable.

See also #349.

Thanks.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions